Official: WCDDL - The DDL Script

[snkr007]

Haha

It's because I implemented 100 lines of JS for AJAX requests and what not, but decided to scrap it and make it all standard instead of AJAX.

Now the admin page is way cleaner.

Approx time left for releasing it ?

[JmZ]

As I said before, 'delayed by a day', so hopefully today.

Mr Happy, here's an example admin module now:

function myAdminPage($go) {
     if($go != 'myAdminPage') return false;
     // output some html here
     // and handle things
}

Core::load()->hook('AdminHandleContent', 'myAdminPage'); 

This'll make your mod page display when ?go=myAdminPage.

[t3od0r]

so....now we have to add the admin links manually in admin page? i am a little confused

[JmZ]

No it is a configuration/setting in the database now.

You use:

Core::load()->config('name', 'value'); 

To set a configuration entry.

The admin_links entry contains an array of admin links, so you could do something like this in your mod:

function myAdminLinks() {
     $links = Core::load()->parseConfig('admin_links');
     $linksCount = count($links);
     $myLinks = array(
          array('?go=myAdmin', 'SomeThing'),
          array('?go=myOtherAdmin', 'Another Thing')
     );
     // I didnt use array_merge because it will allow duplicate entries
     $links = Common::arrayMergeUnique($links, $myLinks);
     if(count($links) != $linksCount)
          Core::load()->config('admin_links', $links);
}
Core::load()->hook('AdminInit', 'myAdminLinks'); 

Yes this is way more complicated than in wcddl2, but it means links are stored.

So you can either use something like the above method, or make a sort of install script, then run it once.

E.g. make an installMyMod() function and hook it so it runs on ?go=installMyMod.

[Smith]

I have feature suggestion JmZ. How about adding static page creator. A lot of people have DMCA, TOS, Advertise and other pages, so mod for that would be useful, I think. Also "installed by default" contact page would be nice. I know you try to keep it as small as possible but every download need contact and those pages I talked about.

[Mr Happy]

Better idea. On the list modules pade can we have a link for each module that runs installMyMod function. Would also be cool to have a uninstallMyMod link. Maybe use if function exists so it only shows is these functions are available. That way all people have to do is upload the module and click the install link for it.

EDIT
A checkupdateMyMod function would be cool too though not necessary. If the returned code is_numeric the it checks with the version hardboard and displays the builtin message if an update exists

[JmZ]

Hooks exist for you to implement such features.

You can make the update thing by hooking to the admin content, e.g. make an updateCheck page which loops through Core::load()->getModules() and checks each for an update method.

Example:

function updateChecker($go) {
     if($go != 'updateChecker') return false;
     foreach(Core::load()->getModules() as $module) {
          // $module is an array($filename, $path)
          // $filename being like 'wcddl_mymod.php'
          $name = substr($module[0], 6, -4);
          if(function_exists($name . '_updateCheck')) {
               $updateNeeded = call_user_func($name . '_updateCheck');
               if($updateNeeded)
                    echo $name . ' - UPDATE AVAILABLE!<br />';
          }
     }
}

Core::load()->hook('AdminHandleContent', 'updateChecker'); 

[Mr Happy]

Hooks exist for you to implement such features.

You can make the update thing by hooking to the admin content, e.g. make an updateCheck page which loops through Core::load()->getModules() and checks each for an update method.

Example:.....

OK I know you can do that but it would be really cool if at least the install one was in by default. I remember with IPB 2.3 that you had to install a Plugin Manager first in order to be able to install and configure lots of modules. Most wouldn't work on their own. I know I could create a Plugin Manager like what the early IPB had to offer the install, uninstall, update options but I think it would be better if at least the install options were in by default.

Just do a config bit in the list modules that searches for the function eg configMyMod, as from that we can offer the other install/uninstall/update options/settings/whatever. It will only be 10-12 extra lines of code for you to have in the default script.

Let's be honest. At the moment list modules is sorta pointless. If you add the config link (if configMyMod function exists) it would give the whole area purpose and get rid of all those custom install files and other bloated crap that can come with modules.

OFFTOPIC:
Desperately disappointing that this is the only topic on KWWH in the last week (probably longer) that has interested me in any way.

[JmZ]

Yes but my point is, you can just hook your install function into AdminHandleContent as its own admin page, e.g. ?go=installmymod.

And if you want to set cookies, send headers, etc, in there, hook into AdminInit instead and check _GET['go'].

I don't want to make mods use a specific function name to install, i want them to hook in and make their own install page. It shouldn't be too hard.

[Mr Happy]

That's a fair point. I see now why you don't want to do that and your probably right. I've another feature request. Again I don't mind if it's not added but I think it could be useful and I know this could easily be done as a hook but that relies on people adding it which most probably wouldn't so hear me out.


Why not include a submit api system by default that would return a json reply saying if submits were rejected and why. eg site is banned, not whitelisted etc or how many were accepted.

Then in three months or whenever you find time to update warezlinkers/auto you can have it give a far more accurate response. Right now it just says downloads submitted even if they are rejected by the DDL site. This is where rardownloads is slightly better as it tries to crawl the returned page and shows the error message if they were rejected. It's really useful.

With rardownloads and linkplz-auto now the top autosubmitters you could use this to regain ground.

It's also better for the DDL admin as by just returning a json reply it's less stress on the server.
Everyone wins. Interested to hear what you think.